-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Planck mass #83
Comments
So the value we have does round to the value you're expecting at the precision you're quoting. It is a little bit different from the CODATA values in the fourth decimal place, although I believe our value is within the quoted uncertainty. It is slightly different from the value quoted in MathWorld, although they don't cite where they get their values from. I suspect that almost all of the difference is due to uncertainty in Newton's constant and indeed if I change our definition of Newton's constant in Looking deeper, it looks like we're using the 2010 CODATA value. Therefore I think the fix is to update our definition of G to the most recent CODATA value. |
See #84 |
Thank you for the quick response! I was actually more concerned that the values are different by a factor of 1000. |
I will note ,the PR in #84, didn't actually address the issue, that was fixed in version 2.0.0, previously |
This was actually fixed in #65, which was a relatively large PR (and the one that made the major version bump to 2.0) It was not the goal of the PR, but the result was that this particular incorrect value (and maybe others) were fixed by the overall code reorganization involving these constants. (specifically, commit 374175c) |
Ah sorry, I missed that you were using an old version. |
Ah, perfect. Thank you @ksunden and @ngoldbaum! |
Ah that’s because I don’t really use the github release interface, I just upload things to pypi. The only reason we have one for 1.0.7 is because JOSS asked for it. |
Description
I am doing some calculations with Planck units.
What I Did
I expected to get a value of
2.177e-8
kg.See for example https://physics.nist.gov/cgi-bin/cuu/Value?plkm, http://scienceworld.wolfram.com/physics/PlanckMass.html
The correct value is calculated in
unyt/_physical_ratios.py
but it seems to be used incorrectly somewhere inunyt/_unit_lookup_table.py
.The text was updated successfully, but these errors were encountered: