Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/24tv.ua] Add extractors #5121

Merged
merged 9 commits into from
Oct 4, 2022

Conversation

coletdjnz
Copy link
Member

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #4287

Adds support for 24tv's custom video embed.

I also added support for extracting embeds from articles. Sometimes the iframe embeds are url encoded and stored within an html attribute, but would otherwise be able to be extracted via generic. To make this work I extract the url encoded HTML iframe, decode it, then return it back to generic via a data url. It is a bit hacky but I'm not sure what other way would be best to do this.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@coletdjnz coletdjnz added the site-request Request to support a new website label Oct 3, 2022
yt_dlp/extractor/tv24ua.py Outdated Show resolved Hide resolved
yt_dlp/extractor/tv24ua.py Outdated Show resolved Hide resolved
@pukkandan pukkandan merged commit 1e0daeb into yt-dlp:master Oct 4, 2022
@coletdjnz coletdjnz deleted the extractor/24tvua branch October 4, 2022 06:36
coletdjnz added a commit that referenced this pull request Oct 14, 2022
Extracts embeds from escaped HTML within `data-html` attribute.
Related: ytdl-org/youtube-dl#21294, #5121

Authored by: coletdjnz
Co-authored-by: pukkandan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading the wrong video
2 participants