fix header existence logic, exactly treat as null or empty string #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are pretty important that improves checking header key existence inside
if
condition.In Fastly runtime, the not-set header, means header is not exist will be false in if condition.
However, the empty string value even header key exists, it would be true in if condition.
Fastly fiddle: https://fiddle.fastly.dev/fiddle/ed2a5dbb
This bug comes from golang's zero-value relating things... it's very helpful for real world usage but not for reproducing VCL runtime X(