[INT-201] #CheckWithTech enhancements #168
Conversation
| @@ -36,7 +36,7 @@ const envSchema = z.object({ | |||
| SLACK_CLIENT_ID: slackEnvType, | |||
| SLACK_CLIENT_SECRET: slackEnvType, | |||
| SLACK_TEAM_ID: z.string().optional(), | |||
| SLACK_CHECK_WITH_TECH_CHANNEL: slackEnvType.default("#check-with-tech"), | |||
| SLACK_CHECK_WITH_TECH_CHANNEL: slackEnvType, | |||
There was a problem hiding this comment.
ACHTUNG: there's some places that the slack API requires a channel ID, so I remove the default here. We need to make sure the ID is set in ystv/nomad prior to merging.
|
Deployed a preview of this PR to https://pr-168-internal.dev.ystv.co.uk |
| }, | ||
| }); | ||
| if (!actor) { | ||
| await respond({ |
There was a problem hiding this comment.
Can we have this message only show for the user that clicked it?
There was a problem hiding this comment.
Fairly sure that this should be an ephemeral message, per https://api.slack.com/interactivity/handling#publishing_ephemeral_response
There was a problem hiding this comment.
I thought that's what it was but couldn't remember if it was something different for slack
There was a problem hiding this comment.
I've got two accounts on my dev instance and can see the messages on both
| return; | ||
| } | ||
| if (!userHasPermission(actor.user_id, "CheckWithTech.Admin")) { | ||
| await respond({ |
There was a problem hiding this comment.
Same with only showing to the single user
|
|
|
| @@ -22,6 +22,8 @@ export const PermissionEnum = z.enum([ | |||
| "Calendar.Public.Admin", | |||
| "Calendar.Public.Creator", | |||
| "CalendarIntegration.Admin", | |||
| "CheckWithTech.Submit", | |||
There was a problem hiding this comment.
What does this permission do, does this stop people submitting requests if they don't have it?
There was a problem hiding this comment.
And doesn't show the prompt at all - essentially intended as a feature flag.
markspolakovs
deleted the
int-201-expand-checkwithtech-into-full-website-feature
branch
TODO: