Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prometheus metrics #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Prometheus metrics #1

wants to merge 1 commit into from

Conversation

markspolakovs
Copy link
Member

Things that it may be worth looking at:

  • SRT metrics (I have no idea how to test it)

probablybenallen
probablybenallen requested changes Jan 30, 2022
View reviewed changes
Copy link
Member

@probablybenallen probablybenallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics endpoints needs securing (however works best with Prometheus, I don't really mind, just some sort of auth scheme), rest of it looks good though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probablybenallen probablybenallen probablybenallen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markspolakovs @probablybenallen