Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BDGR-103] Convert desktop codebase and builds to ES Modules #482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

markspolakovs
Copy link
Member

@markspolakovs markspolakovs commented Jul 9, 2024

Fun drive-by: I think I've finally got to the bottom of why the Prisma client was getting bundled into the Desktop build (where it has no reason to end up and is effectively dead code): I needed to add "sideEffects": false to the utility/prisma/package.json. Added an eslint rule against importing @badger/prisma/client as an extra safeguard.

Fixes BDGR-103, #281.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.16%. Comparing base (e300a52) to head (a45af14).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #482    +/-   ##
========================================
  Coverage   22.16%   22.16%            
========================================
  Files          96       96            
  Lines        3614     3614            
  Branches      594      606    +12     
========================================
  Hits          801      801            
+ Misses       2812     2664   -148     
- Partials        1      149   +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants