Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows steps replays on error #754

Merged

Conversation

loicalbertin
Copy link
Member

Pull Request description

Description of the change

This PR enable the feature of replaying steps in error.

What I did

  • Updated documentation of the API endpoint to update a step state (most of the work was already done but not documented)
  • Allow step state modification from error to initial
  • Deprecate the 'yorc dep tasks fix' command
  • Add a new 'yorc dep tasks update-step-state' command
  • Fix resume issue by deleting .cancelFlag & .errorFlag on task when resuming it

How to verify it

The easiest way to test it is to simulate a network connectivity issue when provisioning an infrastructure resource or submitting a job. VPNs may help here 😄.
Then you should use the new command yorc dep tasks update-step-state <depID> <taskID> <stepName> initial to set the step state to initial and finally resume the tasks using yorc dep tasks resume <depID> <taskID>.

Description for the changelog

  • Workflows steps replays on error (GH-753)

Applicable Issues

Fixes #753

- Update documentation of the API endpoint to update a step state
  (most of the work was already done but not documented)
- Authorize step state modification from error to initial
- Deprecate the 'yorc dep tasks fix' command
- Add a new 'yorc dep tasks update-step-state' command
- Fix resume issue by deleting .cancelFlag & .errorFlag on task when
  resuming it
@loicalbertin loicalbertin self-assigned this Jul 6, 2021
@loicalbertin loicalbertin requested a review from laurentganne July 6, 2021 14:53
Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2021

@laurentganne laurentganne merged commit f95572a into develop Sep 9, 2021
@laurentganne laurentganne deleted the feature/GH-753_Workflows_steps_replays_on_error branch September 9, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows steps replays on error
2 participants