-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows steps replays on error #754
Merged
laurentganne
merged 6 commits into
develop
from
feature/GH-753_Workflows_steps_replays_on_error
Sep 9, 2021
Merged
Workflows steps replays on error #754
laurentganne
merged 6 commits into
develop
from
feature/GH-753_Workflows_steps_replays_on_error
Sep 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update documentation of the API endpoint to update a step state (most of the work was already done but not documented) - Authorize step state modification from error to initial - Deprecate the 'yorc dep tasks fix' command - Add a new 'yorc dep tasks update-step-state' command - Fix resume issue by deleting .cancelFlag & .errorFlag on task when resuming it
laurentganne
reviewed
Jul 6, 2021
laurentganne
reviewed
Jul 6, 2021
laurentganne
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 👍
loicalbertin
commented
Jul 7, 2021
loicalbertin
commented
Jul 7, 2021
SonarCloud Quality Gate failed. |
laurentganne
deleted the
feature/GH-753_Workflows_steps_replays_on_error
branch
September 9, 2021 11:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
This PR enable the feature of replaying steps in error.
What I did
How to verify it
The easiest way to test it is to simulate a network connectivity issue when provisioning an infrastructure resource or submitting a job. VPNs may help here 😄.
Then you should use the new command
yorc dep tasks update-step-state <depID> <taskID> <stepName> initial
to set the step state to initial and finally resume the tasks usingyorc dep tasks resume <depID> <taskID>
.Description for the changelog
Applicable Issues
Fixes #753