Fix Consul connections over consumtion on task monitoring #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the underlying http request to handle context cancellation and release the connection as soon as the local execution is done not after an http timeout
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Jun 11, 2021
loicalbertin
deleted the
bugfix/GH-745_Over_consumption_of_Consul_connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
What I did
Just added the context to the consul query options.
This context is then passed to the http request used by the Consul client and finally can be used for request cancellation
How to verify it
Generate a high load of job monitoring actions for exemple by using a monitoring interval of
0.5sand monitor the consul connections using for instancelsof. It should remain constantDescription for the changelog
Applicable Issues
Fixes #745
Backported to 4.1.x in PR #747
Backported to 4.1.x in PR #748