Bugfix/gh 733 action no stop #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
loicalbertin
approved these changes
May 7, 2021
| @@ -104,7 +104,16 @@ func UnregisterAction(client *api.Client, id string) error { | |||
| // UpdateActionData updates the value of a given data within an action | |||
| func UpdateActionData(client *api.Client, id, key, value string) error { | |||
|
|
|||
| //TODO check if action exists | |||
| scaKeyPath := path.Join(consulutil.SchedulingKVPrefix, "actions", id, "data", key) | |||
| // check if action still exists | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Description of the change
Fixed an issue where a workflow will be seen running forever when a synchronous step failed while an asynchronous run action is taking place at the same time. The asynchronous action was unscheduled as expected but its status was not updated and was seen as running forever.
Fixed also an issue when the asynchronous action is updating its action data: there was no check to see if the action has been unregistered, and the action data was added, leaving an isolated key in consul.
What I did
prov/scheduling/scheduler/consul_test.goprov/scheduling/scheduler/scheduler_test.go:Added a test on UpdateActionData()
prov/scheduling/scheduling.go:Updating action data only when the action data deploymentID key exists
tasks/workflow/worker.go:On task failure, call endAction()
Description for the changelog
Workflow with asynchronous action never stops after another step failure (GH-733)
Applicable Issues
Closes #733