Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/bugfix/bugfix/gh 77 dep status issue #292

Merged

Conversation

stefbenoist
Copy link
Contributor

Pull Request description

Backport bugfix #285

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #292 into release/3.1 will increase coverage by 0.08%.
The diff coverage is 70%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.1     #292      +/-   ##
===============================================
+ Coverage        39.15%   39.23%   +0.08%     
===============================================
  Files              165      165              
  Lines            15370    15374       +4     
===============================================
+ Hits              6018     6032      +14     
+ Misses            8377     8369       -8     
+ Partials           975      973       -2
Impacted Files Coverage Δ
deployments/definition_store.go 68% <70%> (+0.15%) ⬆️
prov/scheduling/scheduler/scheduler.go 72.51% <0%> (ø) ⬆️
tasks/workflow/step.go 38.32% <0%> (+0.69%) ⬆️
prov/monitoring/monitoring_mgr.go 63.8% <0%> (+1.11%) ⬆️
prov/scheduling/scheduler/scheduled_action.go 68.91% <0%> (+6.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce6e77...2deb810. Read the comment docs.

Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: looks good!

@stefbenoist stefbenoist merged commit 7182122 into release/3.1 Feb 1, 2019
@stefbenoist stefbenoist deleted the backport/bugfix/bugfix/gh-77-dep-status-issue branch February 1, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants