Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/gh 218 nfs client #232

Merged
merged 7 commits into from
Dec 13, 2018
Merged

Bugfix/gh 218 nfs client #232

merged 7 commits into from
Dec 13, 2018

Conversation

laurentganne
Copy link
Contributor

@laurentganne laurentganne commented Dec 13, 2018

Pull Request description

Description of the change

Including in the tosca components zip bundled within the orchestrator a fix for the NFS client mount of the NFS server exported file system addressed in the Forge by fix for ystia/forge#38

In addition, added in versions.yaml the Alien4Cloud version that the bootstrap will download from Alien4Cloud public site by default (the user can define a download URL if he doesn't want to use the default one).

Previously this version was deduced from the versions of a4c forge components bundled within Yorc for the bootstrap, but it's better to not have this dependency so that:

  • the version in versions.yaml and installed on bootstrapped infrastructure can follow deliveries of A4C milestones
  • the version of TOSCA components within the zip bundled in Yorc and used by the bootstrap process only, can be updated when necessary (mainly, to take into account a4C forge components bug fixes impacting the bootstrap)

How to verify it

On a CentOS 7 compute instance created on google cloud,
donwload a Yorc from this pull request build.

Create a file input_values.yaml with the following content.
Warning: before the merge of ystia/yorc-a4c-plugin#75 taking care of making the plugin compatible with A4C 2.1.0-RC1,
you need to use the plugin from this plugin pull request for the bootstrap, by adding these lines to the values file:

yorc_plugin:
   download_url: https://dl.bintray.com/ystia/yorc-a4c-plugin/snapshots/feature/GH-196-a4c-sm7-jobs-enhancements/alien4cloud-yorc-plugin-3.1.0-SNAPSHOT.zip  

It gives this input file, you have to update to specify your user and creds file:

yorc:
  private_key_file: /home/<myuser>/.ssh/<my private key>
yorc_plugin:
   download_url: https://dl.bintray.com/ystia/yorc-a4c-plugin/snapshots/feature/GH-196-a4c-sm7-jobs-enhancements/alien4cloud-yorc-plugin-3.1.0-SNAPSHOT.zip  
infrastructures:
  google:
    application_credentials: /path/to/<my-project Service Account key file>.json
    project: <my-project>
address:
  region: europe-west1
compute:
  image_project: centos-cloud
  image_family: centos-7
  machine_type: n1-standard-1
  zone: europe-west1-b
  metadata: "ssh-keys=<My user>:<my public key>"
  tags: a4c
credentials:
  user: <myuser>

Then bootstrap a HA deployment running :

./yorc bootstrap --values input_values.yaml --deployment_type HA

Description for the changelog

Bootstrap of HA setup fails on GCP, at step configuring the NFS Client component (GH-218)

Applicable Issues

#218

@laurentganne laurentganne self-assigned this Dec 13, 2018
@laurentganne laurentganne added the bug Something isn't working label Dec 13, 2018
@laurentganne laurentganne added this to the 18.12.2 milestone Dec 13, 2018
@laurentganne laurentganne removed the bug Something isn't working label Dec 13, 2018
@laurentganne laurentganne removed this from the 18.12.2 milestone Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #232 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
+ Coverage    39.51%   39.53%   +0.02%     
===========================================
  Files          163      163              
  Lines        14990    14990              
===========================================
+ Hits          5923     5926       +3     
+ Misses        8120     8117       -3     
  Partials       947      947
Impacted Files Coverage Δ
prov/monitoring/monitoring_mgr.go 62.68% <0%> (ø) ⬆️
prov/scheduling/scheduler/scheduler.go 74.59% <0%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc2cb7...c5dd062. Read the comment docs.

@stefbenoist
Copy link
Contributor

It works well !

@laurentganne laurentganne merged commit 31258d3 into develop Dec 13, 2018
@laurentganne laurentganne deleted the bugfix/GH-218-NFS-client branch December 13, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants