Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 77 scale a container on gke #190

Merged
merged 7 commits into from
Oct 26, 2018

Conversation

loicalbertin
Copy link
Member

@loicalbertin loicalbertin commented Oct 25, 2018

Pull Request description

Description of the change

Implement a custom operation that allows to scale a k8s container deployment unit.

What I did

  • Implement scaling within the k8s integration
  • Support custom command with interfaces names different from custom

Applicable Issues

PR ystia/yorc-a4c-plugin#66 is required

Fixes #77

@loicalbertin loicalbertin added the enhancement New feature or request label Oct 25, 2018
@loicalbertin loicalbertin self-assigned this Oct 25, 2018
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #190 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    42.47%   42.52%   +0.04%     
===========================================
  Files          144      144              
  Lines        13247    13253       +6     
===========================================
+ Hits          5627     5636       +9     
+ Misses        6752     6749       -3     
  Partials       868      868
Impacted Files Coverage Δ
rest/structs.go 14.28% <ø> (ø) ⬆️
rest/dep_custom.go 0% <0%> (ø) ⬆️
tasks/workflow/task_execution.go 0% <0%> (ø) ⬆️
tasks/workflow/worker.go 1.76% <0%> (-0.03%) ⬇️
prov/monitoring/monitoring_mgr.go 62.96% <0%> (ø) ⬆️
prov/scheduling/scheduler/scheduler.go 83.18% <0%> (+7.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e496a...4d340a6. Read the comment docs.

Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@loicalbertin loicalbertin merged commit a6b5057 into develop Oct 26, 2018
@loicalbertin loicalbertin deleted the feature/GH-77-scale-a-container-on-gke branch October 26, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants