Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parses value assignments literals directly as string. #138

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Parses value assignments literals directly as string. #138

merged 1 commit into from
Aug 14, 2018

Conversation

loicalbertin
Copy link
Member

Resolves #137.

@loicalbertin loicalbertin added the bug Something isn't working label Aug 14, 2018
@loicalbertin loicalbertin self-assigned this Aug 14, 2018
laurentganne
laurentganne approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

loicalbertin added a commit that referenced this pull request Aug 14, 2018
@loicalbertin
Install jmespath lib by default in the Docker image.
2e016c1 
Document extra-dependencies for Ansible that could be installed.

Resolves #138
@codecov
Copy link

codecov bot commented Aug 14, 2018 •
edited
Loading

Codecov Report

Merging #138 into develop will increase coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
+ Coverage    43.54%   43.57%   +0.02%     
===========================================
  Files          129      129              
  Lines        12014    12023       +9     
===========================================
+ Hits          5232     5239       +7     
- Misses        5933     5934       +1     
- Partials       849      850       +1
Impacted Files Coverage Δ
tosca/value_assignment.go 94.01% <89.47%> (-1.36%) ⬇️
prov/monitoring/monitoring_mgr.go 62.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdbfca...6655c83. Read the comment docs.

@loicalbertin loicalbertin merged commit 1853339 into develop Aug 14, 2018
@loicalbertin loicalbertin deleted the hotfix/GH-137_yaml_parser_value_assignments_literal_as_string branch August 14, 2018 14:21
loicalbertin added a commit that referenced this pull request Aug 17, 2018
@loicalbertin
Install jmespath lib by default in the Docker image.
2b170a6 
Document extra-dependencies for Ansible that could be installed.

Resolves #138
@loicalbertin loicalbertin added this to the 3.1.0-M2 milestone Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentganne laurentganne laurentganne approved these changes

Assignees

@loicalbertin loicalbertin

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@loicalbertin @laurentganne