Merge pull request #747 from ystia/backport_41/bugfix/GH-745_Over_con…

…sumption_of_Consul_connections [backport 41] Fix Consul connections over consumtion on task monitoring
ystia · Jun 11, 2021 · b721fc9 · b721fc9
2 parents c1876bc + bc1e530
commit b721fc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## UNRELEASED
 
+### BUG FIXES
+
+* Over-consumption of Consul connections ([GH-745](https://github.com/ystia/yorc/issues/745))
+
 ## 4.1.1 (May 06, 2021)
 
 ### ENHANCEMENTS

diff --git a/tasks/tasks.go b/tasks/tasks.go
@@ -625,15 +625,11 @@ func MonitorTaskFailure(ctx context.Context, taskID string, f func()) {
 func monitorTaskFlag(ctx context.Context, taskID, flag string, value []byte, f func()) {
 	go func() {
 		var lastIndex uint64
+		queryMeta := &api.QueryOptions{}
+		queryMeta = queryMeta.WithContext(ctx)
 		for {
-			select {
-			case <-ctx.Done():
-				log.Debugf("Task monitoring for flag %s exit", flag)
-				return
-			default:
-			}
-
-			kvp, qMeta, err := consulutil.GetKV().Get(path.Join(consulutil.TasksPrefix, taskID, flag), &api.QueryOptions{WaitIndex: lastIndex})
+			queryMeta.WaitIndex = lastIndex
+			kvp, qMeta, err := consulutil.GetKV().Get(path.Join(consulutil.TasksPrefix, taskID, flag), queryMeta)
 
 			select {
 			case <-ctx.Done():