Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TOSCA component to load a docker image from a tar archive #140

Open
laurentganne opened this issue Oct 20, 2020 · 3 comments · May be fixed by #148
Open

Add a TOSCA component to load a docker image from a tar archive #140

laurentganne opened this issue Oct 20, 2020 · 3 comments · May be fixed by #148
Assignees
Labels
enhancement New feature or request

Comments

@laurentganne
Copy link
Contributor

The TOSCA component org.ystia.docker.containers.docker.generic.nodes.GenericContainer allows to create a docker container from an image in a docker repository.
But In some use cases, the image is not available in a docker repository. This image is available in the filesystem as a tar archive.

A new TOSCA component could be added in the Forge to be able to load a docker image from a tar archive.

@laurentganne laurentganne added the enhancement New feature or request label Oct 20, 2020
@laurentganne laurentganne self-assigned this Oct 20, 2020
@loicalbertin
Copy link
Member

loicalbertin commented Oct 23, 2020

Are you thinking about a DockerImagecomponent that will manage images in the local registry?
I think it could be interesting as we would be able to download an image from a registry, load it from a tgz file or even build it... and finally remove it in delete phase.
We could do this incrementally, WDYT?

We may take inspiration from https://docs.ansible.com/ansible/latest/collections/community/general/docker_image_module.html#ansible-collections-community-general-docker-image-module

@laurentganne
Copy link
Contributor Author

Actually as this ansible module has many parameters, some making sense only for a build, others only for a load, etc... I was thinking to make specialized components, like in this implementation: https://github.com/ystia/forge/blob/feature/GH-140-docker-image-loader/org/ystia/docker/images/types.yml of an Image Loader component, and we could have another component called image builder, etc... This way I'm exposing just the properties I need for the operation I wan to do (here load a tar archive), what do you think ?

@loicalbertin
Copy link
Member

Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants