handle backticks within inline code blocks #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The surrounding backticks should be N+1, where N is the longest stretch of backticks within the string.
This isn't quite working, because of #171, which is due to upstream. But I have the tests now, and this is good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An inline code block starts with a string of at least one backtick, but possibly more:
`,``, etc. It then continues until that same sting again.The actual surrounding backticks don't matter, as long as they don't appear in the contents. The following are equivalent, and both produce
a``b:The easiest way to handle this is to count the longest stretch of backticks in the contents, and then use a string of N+1 backticks for the inline code markers. So, that's what this PR does.
I can imagine nicer formatting, like finding the first available empty spot; or maybe just special-casing
``. But for now, I'm keeping things simple.If the contents start or end with backspace, we add a single space on either side of the contents (between it and the backticks). The CommonMark spec says these should be stripped on parse; they're currently not, because of newly-filed #171.
This PR resolves #157.