add "chained" integ tests #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are tests where things select themselves, to make sure the second one is superflous.
also, allow marking them as not needed; they're not always relevant to every toml file
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are tests of chaining a selector into a selector of the same type, like
# foo | #foo. This should always apply a second filter to the same elements; it basically ANDs them together.I added these tests for tables initially, since there are separate Table and TableSlice variants for MdElemRef; this meant that the chaining needed to be specifically supported, and was no longer a given. But, then I figured I may as well formalize that.
Some toml test case files don't need this, so there's also a mechanism to mark the chained tests as unneeded. Otherwise, a test case file without a case named "chained" will fail (the
build.rswill auto-generate a "chained" test that trivially fails).