Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-referencing footnotes spin mdq into an infinite loop #188

Closed
yshavit opened this issue Aug 26, 2024 · 1 comment · Fixed by #191
Closed

self-referencing footnotes spin mdq into an infinite loop #188

yshavit opened this issue Aug 26, 2024 · 1 comment · Fixed by #191
Labels
bug Something isn't working
Milestone
first beta

Comments

@yshavit
Copy link
Owner

yshavit commented Aug 26, 2024 

Body with some footnote[^1].

[^1]: footnote text references itself[^1].

Body with some footnote1.

We spin into an infinite loop on this even in tree.rs, before even getting to selectors or output.

Footnotes

  1. footnote text references itself1. ↩ ↩2
@yshavit yshavit added the bug Something isn't working label Aug 26, 2024
@yshavit yshavit added this to the first beta milestone Aug 26, 2024
yshavit added a commit that referenced this issue Aug 26, 2024
@yshavit
add test for cycles, but ignored because of #188
62dae9e
@yshavit yshavit mentioned this issue Aug 26, 2024
Merged
@yshavit
Copy link
Owner Author

yshavit commented Aug 26, 2024

Note that this can also happen with a mult-node hop; footnote [^1] references [^2] which references [^1].

yshavit added a commit that referenced this issue Aug 26, 2024
@yshavit
handle footnotes that contain footnotes or links
09e5689 
Links can't contain other links or footnotes -- but footnotes can
contain either. Add tests and logic to handle it.

Resolves #98.

I found #188 (footnotes that cycle back to themselves) while writing
tests for this, but that's a special case, so I'm going to handle it
separately.
@yshavit yshavit mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
first beta
Development

Successfully merging a pull request may close this issue.

separate footnote bodies into a doc-scoped context yshavit/mdq
1 participant
@yshavit