MT: start spinning immediately in #find_next_runnable

Same reasoning as for ST.
ysbaddaden · Sep 27, 2024 · 9203290 · 9203290
1 parent c9716a6
commit 9203290
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/src/multi_threaded/scheduler.cr b/src/multi_threaded/scheduler.cr
@@ -142,23 +142,15 @@ module ExecutionContext
       end
 
       private def find_next_runnable(&) : Nil
-        # try queues & the event loop
-        yield @runnables.get?
-        yield @global_queue.grab?(@runnables, divisor: @execution_context.size)
-
-        if @execution_context.lock_evloop? { @event_loop.run(blocking: false) }
-          yield @runnables.get?
-        end
-
         # nothing to do: start spinning
         spinning do
-          yield try_steal?
-
           if @execution_context.lock_evloop? { @event_loop.run(blocking: false) }
             yield @runnables.get?
           end
 
           yield @global_queue.grab?(@runnables, divisor: @execution_context.size)
+
+          yield try_steal?
         end
 
         # wait on the event loop for events and timers to activate

diff --git a/src/single_threaded.cr b/src/single_threaded.cr
@@ -190,14 +190,6 @@ module ExecutionContext
     end
 
     private def find_next_runnable(&) : Nil
-      # try queues & the event loop
-      # yield @runnables.get?
-      # yield @global_queue.grab?(@runnables, divisor: 1)
-
-      # if @event_loop.run(blocking: false)
-      #   yield @runnables.get?
-      # end
-
       # nothing to do: start spinning
       spinning do
         yield @global_queue.grab?(@runnables, divisor: 1)