Skip to content

Commit

Permalink
stop running test_conv.py script as it no longer exists (apache#18455)
Browse files Browse the repository at this point in the history
* stop running test_conv.py script as it no longer exists

* revert adding mkldnn test for cu* builds
  • Loading branch information
mseth10 authored and ys2843 committed Jun 2, 2020
1 parent bd77217 commit 4732a05
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion cd/python/docker/test_python_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,5 @@ if [[ $mxnet_variant == cpu ]]; then
python3 tests/python/mkl/test_mkldnn.py
fi

python3 tests/python/train/test_conv.py ${test_conv_params}
python3 example/image-classification/train_mnist.py ${mnist_params}

1 change: 0 additions & 1 deletion ci/docker/runtime_functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1938,7 +1938,6 @@ cd_integration_test_pypi() {
pip3 install --user ./wheel_build/dist/*.whl

# execute tests
python3 /work/mxnet/tests/python/train/test_conv.py ${test_conv_params}
python3 /work/mxnet/example/image-classification/train_mnist.py ${mnist_params}
}

Expand Down
1 change: 0 additions & 1 deletion docker/docker-python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ For example:
`./build_python_dockerfile.sh 1.3.0 1.3.0.post0 ~/build-docker/incubator-mxnet`

### Tests run
* [test_conv.py](https://github.com/apache/incubator-mxnet/blob/master/tests/python/train/test_conv.py)
* [train_mnist.py](https://github.com/apache/incubator-mxnet/blob/master/example/image-classification/train_mnist.py)
* [test_mxnet.py](https://github.com/apache/incubator-mxnet/blob/master/docker/docker-python/test_mxnet.py): This script is used to make sure that the docker image builds the expected mxnet version. That is, the version picked by pip is the same as as the version passed as a parameter.

Expand Down
2 changes: 0 additions & 2 deletions docker/docker-python/build_python_dockerfile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ docker_test_image_cpu(){
python_version="${2}"
echo "Running tests on mxnet/python:${image_tag}"
docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/docker/docker-python/test_mxnet.py ${mxnet_version}"
docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/tests/python/train/test_conv.py"
docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/example/image-classification/train_mnist.py"
}

Expand All @@ -67,7 +66,6 @@ docker_test_image_gpu(){
python_version="${2}"
echo "Running tests on mxnet/python:${1}"
nvidia-docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/docker/docker-python/test_mxnet.py ${mxnet_version}"
nvidia-docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/tests/python/train/test_conv.py --gpu"
nvidia-docker run -v ${test_dir}:/mxnet mxnet/python:${image_tag} bash -c "${python_version} /mxnet/example/image-classification/train_mnist.py --gpus 0,1,2,3"
}

Expand Down

0 comments on commit 4732a05

Please sign in to comment.