Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 4.3 EventDispatcher->dispatch definition #78

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Support for Symfony 4.3 EventDispatcher->dispatch definition #78

merged 1 commit into from
Jul 31, 2019

Conversation

Pirokiko
Copy link

@Pirokiko Pirokiko commented Jul 26, 2019

Fix #77 : Huge memory consumption

The definition of the Eventdispatcher->dispatch function has been changed in Symfony 4.3, throwing a deprecation warning.
For large data sets, this means that this deprecation warning is thrown a whole lot of times which takes up a surprising amount of memory.

…ymfony 4.3 and up and Symfony 4.2 and lower
@viniychuk viniychuk merged commit 5f192e7 into youshido-php:master Jul 31, 2019
@mwarnaar
Copy link

mwarnaar commented Aug 8, 2019

@viniychuk Any chance of updating this merge request/commit to packagist?

@florentdestremau
Copy link

I asked on the original issue and no answer for now.

Your can use this line in your composer.json to be up-to-date with master:

        "youshido/graphql-bundle": "dev-master#5f192e7cab00710b03e4dd24169e5cdb32b5fcb6"

@viniychuk
Copy link
Member

Hi, it has been updated, but Packagist hooks didn't work — had to re-connect them.
Any of you guys interested in getting write permissions to repo?

@mwarnaar
Copy link

mwarnaar commented Aug 9, 2019

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory consumption in Symfony 4.3
4 participants