Update to typeahead.js v0.10.5 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll review and merge in the next few days. |
yourabi
added a commit
that referenced
this pull request
Aug 26, 2014
Update to typeahead.js v0.10.5 Thanks @felixbuenemann
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes PR #12, #13.
This version sends less sear queries than v0.10.2. The old version often sends outdated queries, eg. AJAX request for search Abc is still outstanding while result for Abcd has already been received. This was changed in 0.10.3 but broke searches with multiple remote sources, but was fixed in 0.10.4.
0.10.5 only relaxes the jQuery version constraint.
I have tested this gem with search across multiple simultaneos remote sources and prefetch and found no problems.