Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute flash data layout info once and for all when possible #4

Open
wants to merge 2 commits into
base: add-flash-attn-2
Choose a base branch
from

Conversation

fxmarty
Copy link
Collaborator

@fxmarty fxmarty commented Sep 7, 2023

As per title.

Try to remediate this happening at each layer:
image

It helps a bit, but not as much as I hoped (only a few %). It seems that cudaMemcpyAsync that the profiler was showing was mostly an artifact, and is not as long as the profiler suggests, and most of the actual overhead is in index_first_axis and unpad_input.

Now we still have overhead given that the unpad/pad still happens at each layer.
image

Things that would help:

  • Fuse the query/key/value nn.Linear and apply unpadding only once on them (would help a bit but not much)
  • Even better: unpad only once at the beginning at the model, and repad only once at the output of the model. The would remove all the unpad/pad overhead, and on top of that would allow us to save some compute / communication in the various nn.Linear, avoiding to do compute on padded tokens.

I hardly see any of these two options fitting transformers philosophy. The second solution basically involves a complete rewrite of the modeling. The second solution would be very helpful though for training with padding, and for batched inference where the prefill is expensive (maybe code models).

In the current state, the benefits from huggingface#25598 seem too limited compared to what PyTorch 2.1 will provide (aka flash v2 without padding) to justify the integration in transformers. But I think there's a real topic of whether we want to offload efficient training / inference to external libs (TGI, brrr) and have transformers more as a "playground", or whether we are keen to include optimizations as such in transformers (even e.g. in the longer term upstreaming SDPA in transformers, using torch.nested when possible, etc.).

Or if we keep the BT API (that has its limitation and flaws) and rely on that to monkey patch / overwrite transformers code.

cc @younesbelkada @LysandreJik

younesbelkada added a commit that referenced this pull request Feb 21, 2024
* inital commit

* update

* update conversion checkpoint

* update conversion script

* nits

* some fixes

* nits

* merge

* fix permute

* nits

* fix

* nits

* nits

* nits

* fix rope

* fix both rope

* nites

* style

* make sure flax works

* fix flax init code

* fix foward

* nits

* print flax generation out

* current code

* nits

* SIIIIIIIIIIIIIIIIIII

* update

* add new tokenizer

* correct fast tokenizer

* fix conversion

* more comments

* fix modeling and conversion

* nits and nits

* nits testing

* add some tokenization tests

* add some edge cases

* add slow tests and fix them

* fixup

* fix copies for modeling

* fix copies

* add 7B slow tests

* fix

* fix

* fix tests

* make tokenizer cis go green

* styling

* last tokenizer nits

* update jax tests

* fix flax for 7b

* add jit testing 🤗

* cleanups

* isolated nit, inv_freq for rotary_emb.inv_freq

* propagate to jax

* Apply suggestions from code review

Co-authored-by: Sanchit Gandhi <[email protected]>

* adjust test

* fix conversion script

* change name

* correct file names

* update conversion script

* Fix bos and eos token ids in the model configuration (#3)

* update modelling

* update conversion script

* add static cache for gemma

* fix sdpa generate

* fix batched

* multiple fixes

* fix FA2

* final fix

* Rename a few missing strings and filenames (#4)

* merge with upstream main

* fix copies

* fix copies

* fix fixup

* fix fixup

* fix

* fix

* final tests

* fix fx gemma tests

* fix fx bf16/fp16 tests

* update slow fx tests

* fx slow tests: one logits, one generation

* move jit test standalone

* Apply suggestions from code review

* nits

* tokenizer updates

* more tokenization updates: custom GemmaSentencepieceExtrator

* style

* Update src/transformers/cache_utils.py

* Update src/transformers/models/gemma/__init__.py

* Update tests/models/gemma/test_modeling_flax_gemma.py

* small nits

* style

* update tokenization test

* fix the rotary embedding

* with style

* fix slow tests

* WARNING this commit might be very important for precisions

* Update tests/models/gemma/test_modeling_flax_gemma.py

* Update src/transformers/models/gemma/configuration_gemma.py

Co-authored-by: Lysandre Debut <[email protected]>

* Update src/transformers/models/gemma/modeling_flax_gemma.py

Co-authored-by: Lysandre Debut <[email protected]>

* small nits here and there!

* forgotten nit

* remove on the fly computation of inv_freq

* revert previous change, let's be safe and for now re-compute freq cis to make sure it's in float

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <[email protected]>

* Update src/transformers/models/gemma/convert_gemma_weights_to_hf.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update src/transformers/models/gemma/convert_gemma_weights_to_hf.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_flax_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_tokenization_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* Update tests/models/gemma/test_modeling_gemma.py

Co-authored-by: Pedro Cuenca <[email protected]>

* nit conversion script link

* fix some tests

* add not doctest and pr doctest

* repo consistency

* fix last CIs 🚀

* update all readmes

---------

Co-authored-by: younesbelkada <[email protected]>
Co-authored-by: Sanchit Gandhi <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Younes Belkada <[email protected]>
Co-authored-by: sanchit-gandhi <[email protected]>
Co-authored-by: Lysandre Debut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant