Add test root readonly #2976
Add test root readonly #2976
Conversation
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
There was a problem hiding this comment.
Hey, I think we need to break this in two tests - one with readonly true and other with false. We will have a corresponding test in the runtime test, which will check that read operation is successful (maybe create a file and validate the contents) and the the write access will be tested according to config's value.
This is small deviation from the go test, but I think this would be a better test.
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
|
@YJDoc2 HI, I've fixed the code according to the comments. Could you please check the code? |
tests/contest/contest/src/tests/root_readonly_true/root_readonly_tests.rs
Outdated
Show resolved
Hide resolved
| if let Err(e) = test_dir_write_access("/") { | ||
| let errno = Errno::from_raw(e.raw_os_error().unwrap()); | ||
| if errno == Errno::EROFS { | ||
| /* This is expected */ | ||
| } else { | ||
| eprintln!("readonly root filesystem, error in testing write access for path /"); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is ok, but also check for read access is Ok and not err if possible. For the != EROFS case, also add the actual errno in the eprintl for debugging
There was a problem hiding this comment.
I fixed this.
c3c62fb
| let errno = Errno::from_raw(e.raw_os_error().unwrap()); | ||
| if errno == Errno::EROFS { | ||
| eprintln!("readt only root filesystem is false but write access for path / is err"); | ||
| } else { | ||
| /* This is expected */ | ||
| } |
There was a problem hiding this comment.
I think for readonly = false, write access should not give any errors at all. So if it not ok, that should be considered error irrespective of errno.
There was a problem hiding this comment.
I fixed this.
c3c62fb
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
…o add-test-root-readonly
|
@YJDoc2 I fixed code, Could you please check the code? |
Signed-off-by: sat0ken <[email protected]>
|
@YJDoc2 Ping! |
This implements the root_readonly_true validation in #361