Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux: write xattr related codes. #2825

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

Gekko0114
Copy link
Contributor

This is an experimental crate. I'll implement a selinux crate step-by-step.
In this PR, I implemented functions related to xattr.

ref: #2718 #2800

@Gekko0114 Gekko0114 marked this pull request as ready for review June 22, 2024 07:16
@Gekko0114
Copy link
Contributor Author

Hi @utam0k, @YJDoc2,
I've created this small PR adding the functions related to xattr. Could you review it?

@utam0k
Copy link
Member

utam0k commented Jun 25, 2024

I'll visit this PR in a couple of days. Please give me some time.

experiment/selinux/src/xattrs/xattr.rs Outdated Show resolved Hide resolved
experiment/selinux/src/xattrs/xattr.rs Outdated Show resolved Hide resolved
@Gekko0114
Copy link
Contributor Author

Hi @utam0k, @YJDoc2,
Thanks for your comments and fixed them. Could you take a look again when you have time?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (46fb4ba) to head (3123107).
Report is 17 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
+ Coverage   66.27%   66.29%   +0.02%     
==========================================
  Files         131      131              
  Lines       16784    16794      +10     
==========================================
+ Hits        11123    11134      +11     
+ Misses       5661     5660       -1     

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, a couple of questions, and the CI is failing due to unrelated issues, can you rebase on current main so CI will pass? Thanks!

experiment/selinux/src/selinux.rs Outdated Show resolved Hide resolved
experiment/selinux/src/xattrs/xattr.rs Outdated Show resolved Hide resolved
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jun 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

@utam0k should we remove the codecov bot for now? We are not enforcing the coverage value in CI, and also not maintaining a required threshold for it.

@Gekko0114 Gekko0114 force-pushed the xattr branch 2 times, most recently from e6025be to 4706a81 Compare June 29, 2024 13:40
@utam0k
Copy link
Member

utam0k commented Jul 9, 2024

@utam0k should we remove the codecov bot for now? We are not enforcing the coverage value in CI, and also not maintaining a required threshold for it.

+1 for now. But we'd like to improve our code coverage in the future. It encourages us to add the unit tests.

Signed-off-by: Hiroyuki Moriya <[email protected]>
@Gekko0114
Copy link
Contributor Author

Hi @utam0k, @YJDoc2
Thanks for your review comments and I've fixed it. Could you take a look again when you have time?

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@utam0k utam0k merged commit ec2b332 into youki-dev:main Jul 9, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
@Gekko0114 Gekko0114 deleted the xattr branch July 10, 2024 06:40
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/experimental `/experimental`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants