-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selinux: write xattr related codes. #2825
Conversation
I'll visit this PR in a couple of days. Please give me some time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.02%
==========================================
Files 131 131
Lines 16784 16794 +10
==========================================
+ Hits 11123 11134 +11
+ Misses 5661 5660 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, a couple of questions, and the CI is failing due to unrelated issues, can you rebase on current main so CI will pass? Thanks!
@utam0k should we remove the codecov bot for now? We are not enforcing the coverage value in CI, and also not maintaining a required threshold for it. |
e6025be
to
4706a81
Compare
+1 for now. But we'd like to improve our code coverage in the future. It encourages us to add the unit tests. |
Signed-off-by: Hiroyuki Moriya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
This is an experimental crate. I'll implement a selinux crate step-by-step.
In this PR, I implemented functions related to xattr.
ref: #2718 #2800