Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in TODO #2677

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fill in TODO #2677

merged 1 commit into from
Feb 9, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Feb 7, 2024

I forgot to fill them out.

Signed-off-by: utam0k <[email protected]>
@utam0k utam0k requested a review from a team February 7, 2024 12:57
@codecov-commenter
Copy link

Codecov Report

Merging #2677 (3516212) into main (9e35012) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2677      +/-   ##
==========================================
+ Coverage   65.39%   65.40%   +0.01%     
==========================================
  Files         133      133              
  Lines       16942    16942              
==========================================
+ Hits        11079    11081       +2     
+ Misses       5863     5861       -2     

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 7, 2024
@jprendes
Copy link
Contributor

jprendes commented Feb 7, 2024

Thanks @utam0k !
There's a typo in the commit message: s/TOOD/TODO/, otherwise it's perfect :-)

@utam0k utam0k changed the title Fill in TOOD Fill in TODO Feb 9, 2024
@utam0k utam0k merged commit 701085d into youki-dev:main Feb 9, 2024
29 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants