Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: just instead make #2585

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix: just instead make #2585

merged 2 commits into from
Dec 22, 2023

Conversation

bestgopher
Copy link
Contributor

No description provided.

Signed-off-by: bestgopher <[email protected]>
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 22, 2023

Hey, Thanks for the PR! We missed to change this when switching over to just.
I have left a minor wording suggestion, please take a look!

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Dec 22, 2023

@bestgopher I think the last commit with changes did not have the correct Sign-off, so the DCO check if failing. Can you add the sign-off similar to your first commit?

@codecov-commenter
Copy link

Codecov Report

Merging #2585 (66915a5) into main (85ec6d0) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   65.88%   65.90%   +0.02%     
==========================================
  Files         133      133              
  Lines       16819    16819              
==========================================
+ Hits        11081    11085       +4     
+ Misses       5738     5734       -4     

@bestgopher
Copy link
Contributor Author

@bestgopher I think the last commit with changes did not have the correct Sign-off, so the DCO check if failing. Can you add the sign-off similar to your first commit?

@YJDoc2 Done.

scripts/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Yashodhan <[email protected]>
Signed-off-by: bestgopher <[email protected]>
@YJDoc2 YJDoc2 merged commit 9e55163 into youki-dev:main Dec 22, 2023
22 checks passed
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants