Refactor doc test and justfile #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yihuaf
commented
Aug 30, 2023
yihuaf
commented
- Separated doc test into a separated justfile recipe
- Refactor the name of the test related to recipe to follow the same pattern of test-*.
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
yihuaf
added
the
kind/cleanup
YJDoc2
reviewed
Aug 31, 2023
justfile
Outdated
Comment on lines
93
to
99
| clean-test-kind: | ||
| test-kind-clean: |
There was a problem hiding this comment.
I think this should be clean-test-kind as this is not a test, but a cleanup script instead.
justfile
Outdated
Comment on lines
41
to
42
| test-unit: | ||
| cargo test --lib --bins --all --all-targets --all-features |
There was a problem hiding this comment.
Do we not need the LD_LIBRARY_PATH ?
|
@yihuaf , if you're busy with something else, just reply to the above comments, and I can push a commit that makes changes accordingly and merge 👍 |
|
Please go ahead. Thanks!
…On Sun, Sep 24, 2023 at 11:20 PM Yashodhan ***@***.***> wrote:
@yihuaf <https://github.com/yihuaf> , if you're busy with something else,
just reply to the above comments, and I can push a commit that makes
changes accordingly and merge 👍
—
Reply to this email directly, view it on GitHub
<#2330 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEY66HUOZMAL2LG4SYCO6BLX4EPETANCNFSM6AAAAAA4E2PQ3E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sure, no worries! |
Signed-off-by: Yashodhan Joshi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
+ Coverage 64.81% 64.83% +0.02%
==========================================
Files 129 129
Lines 15171 15201 +30
==========================================
+ Hits 9833 9856 +23
- Misses 5338 5345 +7 |
YJDoc2
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.