Refactored the Executor interface yet again #2230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize having to refactor this interface yet again. Previously, we introduced the executor to be a function pointer. This works out nicely because the function pointer in rust can be clone-ed without hassel. However, I realized that using function pointer is way too restrictive for our users. The executor may wish to include additional context when calling the exec function. The function pointer limited the input only
oci spec
. The new constraint is that the struct implementing executor must be clone-able, which we need to carry this struct across process boundry.