Refactor the libcgroups interface #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the name to notify listener - fix the structure to be clone-able Signed-off-by: yihuaf <[email protected]>
yihuaf
changed the title
yihuaf
added
kind/cleanup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2168 +/- ##
==========================================
+ Coverage 64.65% 65.05% +0.39%
==========================================
Files 131 129 -2
Lines 14813 14864 +51
==========================================
+ Hits 9578 9670 +92
+ Misses 5235 5194 -41 |
Changed the libcgroup creation interface to use config struct rather than variables. The creation will also own/consume the config struct. In this way, we don't have to create the cgroup manager upfront. Instead, we can delay the creation of cgroup manager in the process when it is needed. Signed-off-by: yihuaf <[email protected]>
yihuaf
force-pushed
the
yihuaf/cgroup-refactor
branch
from
ad5a698
to
b49eae1
Compare
utam0k
reviewed
Jul 15, 2023
|
This is a breaking change to libcgroup, not libcontainer, right? |
utam0k
reviewed
Jul 15, 2023
Yes. |
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
utam0k
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have 3 more PR.