-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented thiserror
for libcontainer - Part 4
#1912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Signed-off-by: yihuaf <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
- Coverage 66.96% 65.06% -1.90%
==========================================
Files 126 127 +1
Lines 14164 14637 +473
==========================================
+ Hits 9485 9524 +39
- Misses 4679 5113 +434 |
Signed-off-by: yihuaf <[email protected]>
yihuaf
force-pushed
the
yihuaf/thiserror
branch
2 times, most recently
from
May 15, 2023 03:09
164b9f5
to
e986826
Compare
Signed-off-by: yihuaf <[email protected]>
utam0k
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second to last PR. I converted most of the module in crate libcontainer to use
thiserror
. The missing 2 arecontainer
andworkload
. Both of these 2 requires a bit more thinking. Theworkload
requires us to define the Executor type with an Error associated type. The container crate will be the main interface exposed by thelibcontainer
crate. It is easier to review these two changes in a different PR.Note, some of the errors are lumped into a
other
error. Instead, we use tracing to log the context of the error at the source where the error happens. This is a contrast from previously usinganyhow
where the error context are stored in the error itself and logged at the top level.Other tag along:
seccomp_listener
mod, so we can centralize the libseccomp feature related code into a single place. Previously, we have to litterlibseccomp
feature switch all over the place.utils
if they are not shared by multiple module. This can simplify error handling so we don't have to create error inutils
just for a single function.