Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt thiserror for libcgroups #1872

Merged
merged 16 commits into from
May 3, 2023
Merged

Adopt thiserror for libcgroups #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a3a7cd8
convert systemd controllers to thiserror
squili May 1, 2023
97d95f6
finish systemd manager except for the CgroupManager impl
squili May 1, 2023
7762902
refactor controller traits to be internal
squili May 1, 2023
e27d23c
convert v1 controllers to thiserror
squili May 2, 2023
a705c82
convert v2 controllers to thiserror
squili May 2, 2023
0dd154c
make StatsProvider an internal trait
squili May 2, 2023
44ded41
replace v1 stats provider anyhow with thiserror
squili May 2, 2023
35133a6
remove anyhow from v2 stats providers
squili May 2, 2023
35c8039
fix lints
squili May 2, 2023
a9fae84
get rid of doc test error
squili May 2, 2023
79e7aae
convert managers from anyhow to thiserror
squili May 2, 2023
52705df
fix lints
squili May 2, 2023
42daada
get rid of the rest of the references to anyhow
squili May 2, 2023
2e8ac76
AnyManager -> AnyCgroupManager
squili May 3, 2023
30e0fee
fix formatting
squili May 3, 2023
5d01bed
fix lint in libcgroups devices
squili May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion crates/libcgroups/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ cgroupsv2_devices = ["rbpf", "libbpf-sys", "errno", "libc"]
nix = "0.26.2"
procfs = "0.15.1"
log = "0.4"
anyhow = "1.0"
oci-spec = { version = "^0.6.0", features = ["runtime"] }
dbus = { version = "0.9.7", optional = true }
fixedbitset = "0.4.2"
Expand All @@ -32,8 +31,10 @@ rbpf = {version = "0.1.0", optional = true }
libbpf-sys = { version = "1.1.1", optional = true }
errno = { version = "0.3.1", optional = true }
libc = { version = "0.2.142", optional = true }
thiserror = "1.0.40"

[dev-dependencies]
anyhow = "1.0"
oci-spec = { version = "^0.6.0", features = ["proptests", "runtime"] }
quickcheck = "1"
mockall = { version = "0.11.4", features = [] }
Expand Down
Loading