Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errno as unresolved type. #1836

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Fix Errno as unresolved type. #1836

merged 2 commits into from
Apr 23, 2023

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Apr 21, 2023

fix #1812

Tbh, I am not sure why this fixes the error, but it does. I confirmed this commit with an existing PR that fails with issue #1812.

Also add a manual trigger to the CI workflow, so we can manually trigger it on the main branch. In this way, we can quickly see if main branch is broken.

@codecov-commenter
Copy link

Codecov Report

Merging #1836 (b293e8f) into main (554d43c) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
+ Coverage   68.62%   68.65%   +0.03%     
==========================================
  Files         121      121              
  Lines       13327    13323       -4     
==========================================
+ Hits         9145     9147       +2     
+ Misses       4182     4176       -6     

@yihuaf yihuaf requested review from utam0k, YJDoc2 and a team April 21, 2023 23:01
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@utam0k utam0k merged commit 00b7bfd into youki-dev:main Apr 23, 2023
@yihuaf yihuaf deleted the yihuaf/fix-1812 branch April 24, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to resolve: use of undeclared type Errno
3 participants