Update version check in validate_spec to support 1.X.Y version. #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: utam0k <[email protected]>
Previously, the validate_spec function only supported runtime spec versions that started with "1.0". This commit updates the function to support all versions starting with "1." (e.g., 1.X.Y), making it compatible with a broader range of runtime spec versions. Signed-off-by: utam0k <[email protected]>
utam0k
force-pushed
the
spec-version-validate
branch
from
85e1fa4
to
7104494
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
- Coverage 68.64% 68.63% -0.01%
==========================================
Files 121 121
Lines 13324 13325 +1
==========================================
Hits 9146 9146
- Misses 4178 4179 +1 |
yihuaf
approved these changes
Apr 9, 2023
|
@yihuaf Thanks for your review 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the validate_spec function only supported runtime spec versions that started with "1.0".
This commit updates the function to support all versions starting with "1." (e.g., 1.X.Y), making it compatible with a broader range of runtime spec versions.
containerd/runwasi#78 (comment)