[Trivial] Fix makefile targets to use PHONY #1743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all makefile target in Youki is using
.PHONY
target. We don't use any file targets, so fixing it properly for all makefile.On a different note, there has been a lot of popularity in using
justfile
as command runner to invoke different command, especially for Rust projects. Since we use Makefile only as a command runner, I want to bringjustfile
up to see if there is any interest. Note, Makefile is definitely good enough for us. The upside is thatjustfile
is a little more ergonomic being used as a command runner. The downside is that we have to installjustfile
as part of the dependency, whereas Makefile is more readily available. Food for thought :)Reference: https://github.com/casey/just