fix the warns from cargo clippy #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
==========================================
+ Coverage 68.71% 68.78% +0.06%
==========================================
Files 120 120
Lines 13094 13072 -22
==========================================
- Hits 8998 8992 -6
+ Misses 4096 4080 -16 |
Signed-off-by: utam0k <[email protected]>
|
Hey, thanks a lot for opening this 🤗 . As this is not marked WIP, I'll take a look at this and merge if no issue :) |
saschagrunert
approved these changes
Feb 13, 2023
YJDoc2
reviewed
Feb 13, 2023
| @@ -378,7 +374,7 @@ impl Mount { | |||
| if let Some(l) = label { | |||
| if typ != Some("proc") && typ != Some("sysfs") { | |||
| match mount_option_config.data.is_empty() { | |||
| true => d = format!("context=\"{}\"", l), | |||
| true => d = format!("context=\"{l}\""), | |||
| false => d = format!("{},context=\"{}\"", mount_option_config.data, l), | |||
There was a problem hiding this comment.
Hey, why is this part not formatted in the same way? we can format l in the same way here right?
There was a problem hiding this comment.
I'm not sure because this changes created by cargo fmt and clippy
YJDoc2
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: utam0k [email protected]