Add descriptors.json when creating checkpoint #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runc as well as crun create a file called descriptors.json in the checkpoint directory. descriptors.json contains a list of how the FDs 0, 1, 2 are connected before checkpointing: $ cat descriptors.json # created by runc in this case ["/dev/null","pipe:[230688]","pipe:[230689]"] With this information the FDs can be reconnected correctly during restore. With this commit is it possible to do: $ youki run container $ youki checkpointt container $ runc restore container Now the checkpoint is in a format that can be handled by other container runtimes. Signed-off-by: Adrian Reber <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 68.79% 68.71% -0.08%
==========================================
Files 120 120
Lines 13082 13094 +12
==========================================
- Hits 9000 8998 -2
- Misses 4082 4096 +14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runc as well as crun create a file called descriptors.json in the checkpoint directory. descriptors.json contains a list of how the FDs 0, 1, 2 are connected before checkpointing:
$ cat descriptors.json # created by runc in this case ["/dev/null","pipe:[230688]","pipe:[230689]"]
With this information the FDs can be reconnected correctly during restore.
With this commit is it possible to do:
$ youki run container
$ youki checkpointt container
$ runc restore container
Now the checkpoint is in a format that can be handled by other container runtimes.