Automating Dependabot with GitHub Actions #1481
Conversation
Signed-off-by: utam0k <[email protected]>
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Approve & enable auto-merge for Dependabot PR | ||
| if: | | ||
| steps.metadata.outputs.update-type == 'version-update:semver-patch' |
There was a problem hiding this comment.
Only updating a patch version, this workflow runs.
| - name: Automerge | ||
| id: automerge | ||
| uses: pascalgn/[email protected] |
There was a problem hiding this comment.
Should we use gh pr merge --auto --merge "$PR_URL" as written in the link you have mentioned? The automerge action readme states :
This functionality is now available directly in GitHub as auto-merge. Note that GitHub does not currently support auto-rebasing pull requests. The automerge-action project will still be maintained, but users are encouraged to switch to auto-merge for simple workflows, as it offers a faster and more stable experience.
WDYT @utam0k ?
There was a problem hiding this comment.
@YJDoc2 Good point. Auto merge affects the entire repository.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-auto-merge-for-pull-requests-in-your-repository
But I don't think we have CI, unit tests, etc... enough to enable this feature yet.
There was a problem hiding this comment.
I was talking about using gh cli to merge the PR as I have mentioned in the comment, but sure the actions also seems pretty decent.
Also I think we have enough tests and CI checks? correct me if I'm wrong.
I'm approving the PR, as it looks good to me, but not merging ; you can merge it after you see this comment 👍
There was a problem hiding this comment.
Also I think we have enough tests and CI checks? correct me if I'm wrong.
This is debatable. For example, I feel that the wasm and checkpoint features have not been adequately tested with CI. I'd like to get your opinition and if we need, let's create an issue and address it. You opinion is always great and respects it.
There was a problem hiding this comment.
That is true. We can create issues for that and deal with them. For now, this PR should do well 👍
Thanks :)
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request