Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example timers #99

Merged
merged 7 commits into from
Jul 17, 2023
Merged

Add example timers #99

merged 7 commits into from
Jul 17, 2023

Conversation

Myzel394
Copy link
Contributor

This PR adds example quick selection timers to the CreateTimerScreen

This allows users to quickly select from common timers, such as 10 minutes, 15 minutes, half an hour, an hour etc.

out.mp4

@Bnyro
Copy link
Member

Bnyro commented Jul 16, 2023

Thanks for the PR!
I generally like the idea of these changes, however I think that they do not really fit there in terms of their position in the UI. They look very squeezed there at the bottom.
I think we should either place them above or below the current content (number pad + start button).
Hence the size of the number pad buttons should be reduced as well.

@Myzel394
Copy link
Contributor Author

ncs

@Myzel394 Myzel394 requested a review from Bnyro July 17, 2023 16:44
@Myzel394 Myzel394 requested a review from Bnyro July 17, 2023 16:56
@Bnyro
Copy link
Member

Bnyro commented Jul 17, 2023

In my opinion, we can remove the :00 at the end of each example timer, because it should be self-explaining that 1s timers don't make any sense.
Otherwise lgtm!

@Myzel394
Copy link
Contributor Author

Myzel394 commented Jul 17, 2023

In my opinion, we can remove the :00 at the end of each example timer, because it should be self-explaining that 1s timers don't make any sense.

1s doesn't make sense but 30s would make sense for example. I think most people would interpret "01:00" as one minute and not as one hour

@Bnyro
Copy link
Member

Bnyro commented Jul 17, 2023

Agreed, it makes more sense to remove the 00: at the beginning for anything below one hour.

@Myzel394
Copy link
Contributor Author

I'd prefer to keep them also as this makes all timers the same width and thus easier for eyes to read as one can immediately jump to the minutes and hours parts

@Bnyro
Copy link
Member

Bnyro commented Jul 17, 2023

In my opinion that's just wasted space, your screenshot could contain 4 timers instead of the current 3 when removing the 00: at the beginning.

@Myzel394
Copy link
Contributor Author

done

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bnyro Bnyro merged commit 20fb7a7 into you-apps:main Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants