Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a more user friendly time picker #121

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Added a more user friendly time picker #121

merged 2 commits into from
Aug 13, 2023

Conversation

SuhasDissa
Copy link
Member

@Bnyro
Copy link
Member

Bnyro commented Aug 13, 2023

Wow, that looks great!

I would suggest making the Hours, Minutes and Seconds strings translatable, and removing the old NumberPicker component which is now unused, otherwise there's nothing to complain about here :)

@Bnyro
Copy link
Member

Bnyro commented Aug 13, 2023

Please squash and merge that PR :)

@SuhasDissa SuhasDissa merged commit 5738f89 into you-apps:main Aug 13, 2023
1 check passed
@SuhasDissa SuhasDissa deleted the newtimer branch October 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuhasDissa @Bnyro