use ToValue as the bound for captured values #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
This PR allows any
T: ToValue
to be used as the value in a captured key-value pair instead of just strings. See: rust-lang/log#353 where we should also make this change.Description
Instead of expecting a
&[(&str, &str)]
, we can take a&[(&str, &dyn ToValue)]
, which still implements theSource
trait. That way values like integers can also be captured, along with more complex values if they use an adapter.Types of changes