UCT/CM/RDMACM: share dummy CQ per device #105
Conversation
src/uct/ib/rdmacm/rdmacm_cm.c
Outdated
|
|
||
| iter = kh_put(uct_rdmacm_cm_cqs, &cm->cqs, device_name, &ret); | ||
| if (iter == kh_end(&cm->cqs)) { | ||
| ibv_destroy_cq(*cq); |
There was a problem hiding this comment.
I don't think it makes sense here on out-of-memory flow, usually this is an unrecoverable error.
| return UCS_ERR_IO_ERROR; | ||
| } | ||
|
|
||
| iter = kh_put(uct_rdmacm_cm_cqs, &cm->cqs, device_name, &ret); |
There was a problem hiding this comment.
IMO would be simpler to 1st do kh_put and see if already exists by ret, rather than kh_get_kh_put
There was a problem hiding this comment.
kh_put has value arg to put but on first look up no need to create cq bcz it can be there. we can try put NULL-pointer on first try then rewrite by new cq if it's not present in the hash.
IMHO get/put logic clearer, extra lookup is rare event due to limited amount of devices
There was a problem hiding this comment.
ahh, just noticed that I was wrong about value arg, will rework then
|
@evgeny-leksikov pls squash |
evgeny-leksikov
force-pushed
the
uct_rdmacm_cm_shared_cq
branch
from
7221f8d to
2d732f1
Compare
done |
@yosefe @alinask pls take a look