Add integration tree test for sync with js-sdk #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new logical timestamp for identifying the position in
local/remote editing, and ensures commutative editing in concurrent
cases.
This logical timestamp consists of {parentID, leftSiblingID}. This
allows editing at the front of text nodes by using a reference to the
parent, as well as getting rid of the local offset used to access an
element node's children previously by using the leftSiblingID.
---------
Co-authored-by: MoonGyu1 <[email protected]>
Co-authored-by: sejongk <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 69 69
Lines 9880 9880
=======================================
Hits 4808 4808
Misses 4571 4571
Partials 501 501 |
hackerwins
approved these changes
Aug 21, 2023
Wu22e
pushed a commit
to Wu22e/yorkie
that referenced
this pull request
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tree_test.gofor sync with js-sdk's test casesWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: