Update coderabbitai's review

yorkie-team · Jul 20, 2024 · cc3c18b · cc3c18b
1 parent 98dc7c5
commit cc3c18b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/server/backend/database/memory/database.go b/server/backend/database/memory/database.go
@@ -633,9 +633,12 @@ func (d *DB) DeleteUserInfoByName(_ context.Context, username string) error {
 	defer txn.Abort()
 
 	raw, err := txn.First(tblUsers, "username", username)
-	if err != nil || raw == nil {
+	if err != nil {
 		return fmt.Errorf("find user by username: %w", err)
 	}
+	if raw == nil {
+		return fmt.Errorf("%s: %w", username, database.ErrUserNotFound)
+	}
 
 	info := raw.(*database.UserInfo).DeepCopy()
 	if err = txn.Delete(tblUsers, info); err != nil {
@@ -652,9 +655,12 @@ func (d *DB) ChangePassword(_ context.Context, username, hashedNewPassword strin
 	defer txn.Abort()
 
 	raw, err := txn.First(tblUsers, "username", username)
-	if err != nil || raw == nil {
+	if err != nil {
 		return fmt.Errorf("find user by username: %w", err)
 	}
+	if raw == nil {
+		return fmt.Errorf("%s: %w", username, database.ErrUserNotFound)
+	}
 
 	info := raw.(*database.UserInfo).DeepCopy()
 	info.HashedPassword = hashedNewPassword

diff --git a/server/users/users.go b/server/users/users.go
@@ -108,7 +108,7 @@ func DeleteAccountByName(
 	return nil
 }
 
-// ChangePassword deletes a user by name.
+// ChangePassword changes the password for a user.
 func ChangePassword(
 	ctx context.Context,
 	be *backend.Backend,