-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for v0.5.6 #929
Conversation
WalkthroughThe changes in this pull request include the addition of a Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
14-14
: Wrap bare URLs in angle brackets for better markdown formatting.The bare URLs should be wrapped in angle brackets according to markdown best practices.
-by @JOOHOJANG in https://github.com/yorkie-team/yorkie-js-sdk/pull/928 +by @JOOHOJANG in <https://github.com/yorkie-team/yorkie-js-sdk/pull/928> -by @JOOHOJANG in https://github.com/yorkie-team/yorkie-js-sdk/pull/926 +by @JOOHOJANG in <https://github.com/yorkie-team/yorkie-js-sdk/pull/926>Also applies to: 18-18
🧰 Tools
🪛 Markdownlint (0.35.0)
14-14: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)packages/sdk/package.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/sdk/package.json
🧰 Additional context used
🪛 Markdownlint (0.35.0)
CHANGELOG.md
14-14: null
Bare URL used
(MD034, no-bare-urls)
18-18: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
CHANGELOG.md (1)
10-19
: LGTM! The changelog entry is well-structured and complete.
The changelog entry:
- Follows the Keep a Changelog format
- Includes correct version and date
- Properly categorizes changes under "Added" and "Fixed" sections
- Accurately documents the keepalive option addition and GC improvements
- Properly attributes changes to contributors
🧰 Tools
🪛 Markdownlint (0.35.0)
14-14: null
Bare URL used
(MD034, no-bare-urls)
18-18: null
Bare URL used
(MD034, no-bare-urls)
What this PR does / why we need it?
Update CHANGELOG.md for v0.5.6
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist
Summary by CodeRabbit
New Features
keepalive
option in theclient.deactivate
method to maintain connections during deactivation.Bug Fixes
Chores
package.json
file to0.5.6
.