-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify error throwing methods #878
Merged
hackerwins
merged 11 commits into
yorkie-team:main
from
gwbaik9717:unify-error-throwing-methods
Aug 7, 2024
Merged
Unify error throwing methods #878
hackerwins
merged 11 commits into
yorkie-team:main
from
gwbaik9717:unify-error-throwing-methods
Aug 7, 2024
Commits on Jul 26, 2024
-
Separate Error throwing and Logging in logger.fatal
This commit separates the error throwing and logging functionalities in logger.fatal. The logger now solely handles logging messages, while errors are thrown independently using YorkieError.
Configuration menu - View commit details
-
Copy full SHA for 3516dc0 - Browse repository at this point
Copy the full SHA 3516dc0View commit details
Commits on Jul 27, 2024
-
Standardize Error Names for Consistency
This commit standardizes the naming conventions for errors starting with 'Err'
Configuration menu - View commit details
-
Copy full SHA for 92dc6af - Browse repository at this point
Copy the full SHA 92dc6afView commit details
Commits on Jul 28, 2024
-
Replace 'throw new Error' to YorkieError
This commit replaces all instances of throw new Error with YorkieError to provide more specific and consistent error handling throughout the codebase.
Configuration menu - View commit details
-
Copy full SHA for 35be776 - Browse repository at this point
Copy the full SHA 35be776View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30330bb - Browse repository at this point
Copy the full SHA 30330bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c330d - Browse repository at this point
Copy the full SHA b4c330dView commit details
Commits on Aug 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae7461b - Browse repository at this point
Copy the full SHA ae7461bView commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc21654 - Browse repository at this point
Copy the full SHA bc21654View commit details -
Remove logger.fatal when used with 'throw new YorkieError
There is a problem of code being verbose with duuplicated logging and error throwing. Removing logger will temproarily resolve the issue.
Configuration menu - View commit details
-
Copy full SHA for b6c5213 - Browse repository at this point
Copy the full SHA b6c5213View commit details
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e6ae347 - Browse repository at this point
Copy the full SHA e6ae347View commit details -
Configuration menu - View commit details
-
Copy full SHA for f37bf07 - Browse repository at this point
Copy the full SHA f37bf07View commit details -
Configuration menu - View commit details
-
Copy full SHA for d360393 - Browse repository at this point
Copy the full SHA d360393View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.