Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred Weapon Allocation #40

Merged
merged 14 commits into from
Jan 15, 2024
Merged

Preferred Weapon Allocation #40

merged 14 commits into from
Jan 15, 2024

Conversation

yonilerner
Copy link
Owner

@yonilerner yonilerner commented Jan 12, 2024

This PR makes some pretty substantial changes:

  • New WeaponAllocationType that is used to determine what a weapon can be allocated for, replacing round-based allocation
  • All user preferences are based on WeaponAllocationType now
  • Introduces the concept of a "preferred" allocation, which basically means sniper queue, but could be configured in the future to be something else. Currently this is hardcoded to allow only one preferred weapon per team
  • As a result of these changes, the !gun command is actually more flexible since we can now allocate weapons for round types other than the current round, we just wont give it to you immediately
  • Scout is now a mid range weapon

Closes #42
Closes #43
Closes #56

@yonilerner yonilerner marked this pull request as draft January 12, 2024 06:45
@yonilerner yonilerner force-pushed the sniper-allocations branch 2 times, most recently from 3e6c0a9 to a6e36d9 Compare January 13, 2024 04:01
@yonilerner yonilerner changed the title WIP Sniper allocations Preferred Weapon Allocation Jan 14, 2024
@yonilerner yonilerner marked this pull request as ready for review January 14, 2024 06:48
@yonilerner yonilerner requested a review from B3none January 14, 2024 06:48
@yonilerner yonilerner merged commit 79552fb into main Jan 15, 2024
2 checks passed
@yonilerner yonilerner deleted the sniper-allocations branch January 15, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants