Added RatioOfPreferredWeaponPerRound config for configure AWP chance per round. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonilerner
reviewed
Apr 22, 2024
|
@yonilerner I made the requested changes. Should i make a new round type and improve this or is this enough for now? |
|
this change is good as-is, but if you do want to customize more things around the round type, then we should do that instead. However Im concerned adding a new round type is going to be a lot of work. If you want to give it a try though you're more than welcome :) |
|
Then we can close this PR like this and let the users use this way right now. I will make a new PR when I have more time. |
|
Sounds good. if we ever add the new round type, we will need to deprecate this new config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If wanted I can make a new Round Type named FullBuyWithAWP and this way we can configure more details like If round is AWP round give more flashes etc.
But this should solve #122 in very basic way.