Fix viewVerbose JS error #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace separator is `-`, which is not allowed in JavaScript identifiers. Using bracket notation solves this.
|
still getting same behavior. running this app as an example and in the third panel right plot there is a continuous colour aesthetic, which should hide the colourpicker by default.
|
|
I answered on #17. |
|
yeah. we started from that. kirill didnt find that a great feature for running a package... |
|
sorry read the ans now on the ggedit issue page. thank you for finding where the problem is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace separator is
-, which is not allowed in JavaScript identifiers. Usingbracket notation solves this.