Automatically copy XPC Services to correct location #368

brentleyjones · 2018-08-02T12:57:25Z

Fixes #334.

brentleyjones · 2018-08-02T12:57:50Z

@vgorloff Let me know if this resolves your issue.

vgorloff · 2018-08-02T12:59:17Z

Thank you! Will check it today evening or on weekend.

yonaskolb · 2018-08-02T13:49:57Z

Sources/ProjectSpec/TargetSource.swift

@@ -40,6 +40,11 @@ public struct TargetSource: Equatable {
        case carbonResources

        public struct CopyFilesSettings: Equatable, Hashable {
+            public static let xpcServices = CopyFilesSettings(


I like this. We could add a similar static modulemap property.
Could we move it into XcodeGenKit as an extension though?

The main reason I did this one here, is that it shows up in the dropdown for a destination in Xcode, and if you these exact settings Xcode will render it as such.

The modulemap based one is more a convention, and that I would put into an extension in XcodeGenKit.

vgorloff · 2018-08-02T13:58:40Z

Local build from brentleyjones:automatically-copy-xpc fork fixes issue. Thanks!

  macOS-XPCClient:
    type: application
    platform: macOS
    settings:
      INFOPLIST_FILE: Components/macOS/XPCDemo/Client/Info.plist
      PRODUCT_BUNDLE_IDENTIFIER: com.mc.macOS.xpc.Client
      CODE_SIGN_ENTITLEMENTS: Components/macOS/XPCDemo/Client/App.entitlements
      CODE_SIGN_IDENTITY: Mac Developer
      CODE_SIGN_STYLE: Automatic
      DEVELOPMENT_TEAM: JFM85B4M73
    configFiles:
       Debug: ../WL/Shared/Configuration/App-macOS.xcconfig
       Release: ../WL/Shared/Configuration/App-macOS.xcconfig
    sources:
       - Components/macOS/XPCDemo/Common
       - Components/macOS/XPCDemo/Client
    # postbuildScripts:
    #    - script: '[[ -r ~/.bashrc ]] && . ~/.bashrc;
    #    mkdir -p "${BUILT_PRODUCTS_DIR}/${XPCSERVICES_FOLDER_PATH}/";
    #    find "${BUILT_PRODUCTS_DIR}" -depth 1 -type d -name "*.xpc" | xargs -I{} cp -vR "{}" "${BUILT_PRODUCTS_DIR}/${XPCSERVICES_FOLDER_PATH}/"'
    #      name: "Run Script: Embed XPC Service"
    #      shell: /bin/bash
    dependencies:
      - target: macOS-XPCService
        # embed: false
      - target: mcBase-macOS

brentleyjones · 2018-08-07T13:12:48Z

Glad to hear @vgorloff. Hopefully this can make the next release 😄.

yonaskolb · 2018-08-13T11:34:10Z

Tests/Fixtures/TestProject/Project.xcodeproj/project.pbxproj

@@ -26,6 +26,8 @@
 		BF_130062884703 /* Alamofire.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FR_257516580010 /* Alamofire.framework */; };
 		BF_138356261076 /* InterfaceController.swift in Sources */ = {isa = PBXBuildFile; fileRef = FR_363921640403 /* InterfaceController.swift */; };
 		BF_144945303317 /* Alamofire.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = FR_410645050443 /* Alamofire.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
+		BF_156251722120 /* Alamofire.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FR_257516580010 /* Alamofire.framework */; };
+		"BF_156251722120-1" /* Alamofire.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = FR_257516580010 /* Alamofire.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };


Seems a similar issue to that in #373

#373 will fix it.

brentleyjones · 2018-08-15T13:34:51Z

@yonaskolb Good for another look.

brentleyjones · 2018-08-16T12:53:49Z

@yonaskolb We have a lot of good changes in master. Think we can get a new release?

yonaskolb · 2018-09-28T23:52:04Z

@brentleyjones and @vgorloffdid do you know the answer to the question above? Question is should header files in an xpc target generate build files and be added to a build phase?

vgorloff · 2018-09-29T05:46:28Z

Seems it is about ObjC version of XPC Target. I will make a sample XPC ObjC project first and will look on it’s structure.

brentleyjones · 2018-10-01T15:27:54Z

Sorry, I don't know. Thanks @vgorloff for looking into this.

vgorloff · 2018-10-01T19:55:47Z

This is project specs I have for creating ObjC version of XPC Service (XcodeGen version 1.11.2):

name: XPCPingXcodeGen

targets:

  XPCPing:
    type: xpc-service
    platform: macOS
    settings:
      INFOPLIST_FILE: XPCPing/Info.plist
      PRODUCT_BUNDLE_IDENTIFIER: com.example.XPCPing
      CODE_SIGN_IDENTITY: Mac Developer
      CODE_SIGN_STYLE: Automatic
      DEVELOPMENT_TEAM: E27KE6VTF6
    sources:
       - XPCPing
       - Common
       
  XPSClient:
    type: application
    platform: macOS
    settings:
      INFOPLIST_FILE: XPSClient/Info.plist
      PRODUCT_BUNDLE_IDENTIFIER: com.example.XPSClient
      CODE_SIGN_ENTITLEMENTS: XPSClient/XPSClient.entitlements
      CODE_SIGN_IDENTITY: Mac Developer
      CODE_SIGN_STYLE: Automatic
      DEVELOPMENT_TEAM: E27KE6VTF6
    sources:
       - Common
       - XPSClient
    dependencies:
      - target: XPCPing
      
schemes:
   
   XPSClient:
     build:
       targets:
         XPSClient: all

XPCPing.zip

vgorloff · 2018-10-01T19:58:52Z

There could be one or more header files shared between Service and Client.app (like file XPCPingProtocol.h from attached project). Such headers used only to define interface (protocol). Such headers seems not supposed to be part of "Copy Headers" build phase or similar.

yonaskolb · 2018-10-14T11:11:13Z

I ended up just removing build files that didn't belong to any build phases 590128e

yonaskolb reviewed Aug 2, 2018

View reviewed changes

brentleyjones mentioned this pull request Aug 9, 2018

Update CHANGELOG.md #375

Merged

yonaskolb reviewed Aug 13, 2018

View reviewed changes

Automatically copy XPC Services to correct location

341e021

brentleyjones force-pushed the automatically-copy-xpc branch from e783e25 to 341e021 Compare August 15, 2018 13:32

Update CHANGELOG.md

f48f4d9

yonaskolb approved these changes Aug 16, 2018

View reviewed changes

brentleyjones merged commit 43d3b78 into yonaskolb:master Aug 16, 2018

brentleyjones deleted the automatically-copy-xpc branch August 16, 2018 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatically copy XPC Services to correct location #368

Automatically copy XPC Services to correct location #368

brentleyjones commented Aug 2, 2018

brentleyjones commented Aug 2, 2018

vgorloff commented Aug 2, 2018

yonaskolb Aug 2, 2018

brentleyjones Aug 2, 2018

vgorloff commented Aug 2, 2018

brentleyjones commented Aug 7, 2018

yonaskolb Aug 13, 2018

brentleyjones Aug 14, 2018

brentleyjones commented Aug 15, 2018

brentleyjones commented Aug 16, 2018

yonaskolb commented Sep 28, 2018

vgorloff commented Sep 29, 2018

brentleyjones commented Oct 1, 2018

vgorloff commented Oct 1, 2018 •

edited

Loading

vgorloff commented Oct 1, 2018

yonaskolb commented Oct 14, 2018 •

edited

Loading

Automatically copy XPC Services to correct location #368

Automatically copy XPC Services to correct location #368

Conversation

brentleyjones commented Aug 2, 2018

brentleyjones commented Aug 2, 2018

vgorloff commented Aug 2, 2018

yonaskolb Aug 2, 2018

Choose a reason for hiding this comment

brentleyjones Aug 2, 2018

Choose a reason for hiding this comment

vgorloff commented Aug 2, 2018

brentleyjones commented Aug 7, 2018

yonaskolb Aug 13, 2018

Choose a reason for hiding this comment

brentleyjones Aug 14, 2018

Choose a reason for hiding this comment

brentleyjones commented Aug 15, 2018

brentleyjones commented Aug 16, 2018

yonaskolb commented Sep 28, 2018

vgorloff commented Sep 29, 2018

brentleyjones commented Oct 1, 2018

vgorloff commented Oct 1, 2018 • edited Loading

vgorloff commented Oct 1, 2018

yonaskolb commented Oct 14, 2018 • edited Loading

vgorloff commented Oct 1, 2018 •

edited

Loading

yonaskolb commented Oct 14, 2018 •

edited

Loading